fix: truncate long model names in model selector to prevent overflow #6985
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
size:XS
![roomote[bot]](https://avatars.githubusercontent.com/in/1546624?s=60&v=4){kind=small}
| className="w-full justify-between" | ||
| data-testid="model-picker-button"> | ||
| <div>{selectedModelId ?? t("settings:common.select")}</div> | ||
| <div className="truncate">{selectedModelId ?? t("settings:common.select")}</div> |
Contributor
Author
There was a problem hiding this comment.
I notice we're using a <div> here but a <span> on line 197 for the same truncation purpose. Is this intentional? For consistency and semantic correctness (since this is inline text content), would it make sense to use <span> for both?
hannesrudolph
added
the
Issue/PR - Triage
Co-authored-by: roomote[bot] <219738659+roomote[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the issue where long model names overflow the model selector dropdown.
Problem
Really long model names (like
meta-llama/Llama-4-Maverick-17B-128E-Instruct) were overflowing the model selector, making the UI look broken.Solution
Added the
truncateCSS class to both:This ensures that long model names are truncated with ellipsis (...) when they exceed the available width.
Testing
Screenshots
The truncation will now prevent overflow and show ellipsis for long model names, maintaining a clean UI appearance.
Important
Fixes overflow of long model names in
ModelPicker.tsxby addingtruncateCSS class to display elements.truncateCSS class toselectedModelIddisplay inButtonandmodeldisplay inCommandIteminModelPicker.tsxto prevent overflow.ModelPickercomponent passed.This description was created by
for 6e27b6a. You can customize this summary. It will automatically update as commits are pushed.